Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]: AdOpT-NET0: A technology-focused Python package for the optimization of multi-energy systems #7402

Open
editorialbot opened this issue Oct 23, 2024 · 7 comments
Assignees
Labels

Comments

@editorialbot
Copy link
Collaborator

Submitting author: @JeanWi (Jan F. Wiegner)
Repository: https://github.com/UU-ER/AdOpT-NET0
Branch with paper.md (empty if default branch): joss-submission
Version: v0.1.2
Editor: @AdamRJensen
Reviewers: @trevorb1, @datejada
Archive: Pending

Status

status

Status badge code:

HTML: <a href="https://joss.theoj.org/papers/12578885161d419241e50c5e745b7a11"><img src="https://joss.theoj.org/papers/12578885161d419241e50c5e745b7a11/status.svg"></a>
Markdown: [![status](https://joss.theoj.org/papers/12578885161d419241e50c5e745b7a11/status.svg)](https://joss.theoj.org/papers/12578885161d419241e50c5e745b7a11)

Reviewers and authors:

Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) by leaving comments in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)

Reviewer instructions & questions

@trevorb1 & @datejada, your review will be checklist based. Each of you will have a separate checklist that you should update when carrying out your review.
First of all you need to run this command in a separate comment to create the checklist:

@editorialbot generate my checklist

The reviewer guidelines are available here: https://joss.readthedocs.io/en/latest/reviewer_guidelines.html. Any questions/concerns please let @AdamRJensen know.

Please start on your review when you are able, and be sure to complete your review in the next six weeks, at the very latest

Checklists

@trevorb1, please create your checklist typing: @editorialbot generate my checklist

@datejada, please create your checklist typing: @editorialbot generate my checklist

@editorialbot
Copy link
Collaborator Author

Hello humans, I'm @editorialbot, a robot that can help you with some common editorial tasks.

For a list of things I can do to help you, just type:

@editorialbot commands

For example, to regenerate the paper pdf after making changes in the paper's md or bib files, type:

@editorialbot generate pdf

@editorialbot
Copy link
Collaborator Author

Reference check summary (note 'MISSING' DOIs are suggestions that need verification):

✅ OK DOIs

- 10.1016/j.apenergy.2017.07.142 is OK
- 10.1021/acs.iecr.2c00681 is OK
- 10.1016/j.apenergy.2017.01.089 is OK
- 10.1016/j.compchemeng.2022.107816 is OK
- 10.46855/energy-proceedings-5280 is OK
- 10.1038/s41597-019-0199-y is OK
- 10.1016/j.ijrefrig.2021.10.002 is OK
- 10.1021/ACS.IECR.3C02226 is OK
- 10.1016/j.apenergy.2023.120738 is OK

🟡 SKIP DOIs

- No DOI given, and none found for title: Energy system integration options for the North Se...

❌ MISSING DOIs

- None

❌ INVALID DOIs

- None

@editorialbot
Copy link
Collaborator Author

Software report:

github.com/AlDanial/cloc v 1.90  T=0.16 s (1335.3 files/s, 194235.1 lines/s)
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Python                          55           3411           3658          12216
JSON                            90              2              0           4937
SVG                              2             64              0           1642
CSV                             13              0              0           1103
reStructuredText                30            393            310            793
Jupyter Notebook                 3              0            855            245
YAML                             9             38             20            178
Markdown                         2             26              0            139
TeX                              1             10              0            100
TOML                             1              7              0             53
DOS Batch                        1              8              1             26
make                             1              4              7              9
-------------------------------------------------------------------------------
SUM:                           208           3963           4851          21441
-------------------------------------------------------------------------------

Commit count by author:

   331	6574114
   156	Jean
   141	Tiggeloven
    92	julia1071
    64	Jan Wiegner
    25	Luca
    24	Wiegner
    15	IngeOssentjuk
     7	6145795
     7	lucabert01
     2	Bertoni

@editorialbot
Copy link
Collaborator Author

Paper file info:

📄 Wordcount for paper.md is 895

✅ The paper includes a Statement of need section

@editorialbot
Copy link
Collaborator Author

License info:

✅ License found: MIT License (Valid open source OSI approved license)

@editorialbot
Copy link
Collaborator Author

👉📄 Download article proof 📄 View article proof on GitHub 📄 👈

@AdamRJensen
Copy link

Hi @trevorb1, @datejada

Getting started on a review may seem daunting, but even spending just 20 minutes will allow you to check off a few of the first check boxes of the review.

Don't hesitate to reach out if you have question on how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants