Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wireshark Docker Build Fails with WolfSSL Due to Undeclared 'QSC_SIG_CPS' Variable #255

Open
shyamarshid opened this issue Jan 9, 2024 · 2 comments
Labels
good first issue Good for newcomers

Comments

@shyamarshid
Copy link

Description

Building Wireshark with WolfSSL support using the provided Dockerfile (after adding wolfssl support) fails due to an undeclared variable 'QSC_SIG_CPS' in packet-tls-utils.c.

Error Message

/tmp/wireshark-3.4.9/epan/dissectors/packet-tls-utils.c:1259:1: error: 'QSC_SIG_CPS' undeclared here (not in a function); did you mean 'QSC_SIGS'? 1259 | QSC_SIG_CPS

Temporary Fix

Commenting out the following line in the Dockerfile resolves the build issue:
#sed -i "s/ { 0x080b, "rsa_pss_pss_sha512" },/ { 0x080b, "rsa_pss_pss_sha512" },\nQSC_SIG_CPS/g" epan/dissectors/packet-tls-utils.c

This line seems intended to insert QSC-related definitions, but the 'QSC_SIG_CPS' variable is not defined in wolfssl-qsc.h.

Steps to Reproduce

  1. Follow how to enable wolfssl support for this repo mentioned in tutorial : https://www.wolfssl.com/open-quantum-safe-wolfssl-joint-wireshark-integration/
  2. Run docker build -t openquantumsafe/wireshark .
  3. Observe the build error related to 'QSC_SIG_CPS'.
@shyamarshid shyamarshid changed the title Docker Build Fails with WolfSSL Due to Undeclared 'QSC_SIG_CPS' Variable Wireshark Docker Build Fails with WolfSSL Due to Undeclared 'QSC_SIG_CPS' Variable Jan 9, 2024
@baentsch
Copy link
Member

Thanks for this bug report. Not very likely I'll handle this soon as my focus is on supporting completely free, non-commercial software. Will gladly review & accept a suitable PR of course.

@baentsch baentsch added the good first issue Good for newcomers label Jan 10, 2024
@ajbozarth
Copy link
Member

#298 will be marking wireshark as deprecated, but I believe we should leave this issue open to allow new contributors to potentially "un-deprecate" wireshark and update it to working order

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants