Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-passive event listeners destroying performance #56

Open
SSICWeb opened this issue Feb 20, 2022 · 0 comments
Open

Non-passive event listeners destroying performance #56

SSICWeb opened this issue Feb 20, 2022 · 0 comments

Comments

@SSICWeb
Copy link

SSICWeb commented Feb 20, 2022

I believe vue-histogram-slider is based on another library called histogram-slider. I've tried to implement a fix for this as I think we just need to specify passive in any 'touchstart' event listeners. It looks like both the original library and the Vue wrapper have this issue.

All modern browsers report this for each item you iterate through when adding data to the histogram. It kills performance and there is no way that I can see to simply suppress it.

I have over 400 of these messages in my application each time the positions update which is whenever the user moves a map:

image

If these event listeners were updated to have '{ passive: true }', I believe it would correct the issue. I was thinking maybe @oguzhaninan has this setup where he could pull in the updated library and update each 'touchstart' event listener in 15 minutes. I see that there hasn't been an update in two years though. If I can correct this, should we create a new repository where we can keep an updated version? What do you guys suggest?

@oguzhaninan want to chime in? What do you want to do with this if anything? I think it should be kept alive but maybe it needs to be rewritten for Vue3; is this the reason for abandoning it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant