Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation Suggestion #71

Open
harlan-zw opened this issue Sep 11, 2023 · 2 comments
Open

Deprecation Suggestion #71

harlan-zw opened this issue Sep 11, 2023 · 2 comments

Comments

@harlan-zw
Copy link

As this module looks like it never left an experimental stage, I'd suggest that we deprecate it.

cc: @atinux thoughts?

@pi0
Copy link
Member

pi0 commented Sep 11, 2023

Would be worth a benchmark on somewhere like nuxt.com to see if still HTML minifier has performance impacts or not. We have enough hooks and if it improves anything, we might think to either port it to Nuxt 3 (prerender +- runtime) or even part of core ecosystem.

@harlan-zw
Copy link
Author

I actually had to dig through the Nitro code to make sure this wasn't already handled with compressAssets 😆

Afaik the performance improvements are quite negligible so having it opt-in makes more sense to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants