Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix missing query parameters when router.base is a subdirectory. #1827

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

izumiya
Copy link

@izumiya izumiya commented Feb 10, 2023

Hello.
I have fixed a problem with query parameters being lost even with fullPathRedirect enabled.
The problem occurs when a subdirectory is specified in router.base in nuxt.config.js as follows.

export default {
  router: {
    base: '/app/'
  },
  auth: {
    fullPathRedirect: true
  }
}

This problem is caused by normalizePath being executed on the URL retrieved by this.$storage.getUniversal('redirect').
To avoid this problem, I have changed where normalizePath is executed.

For example, if you intended to forward to https://localhost/app/foo?bar=123 after login
/foo?bar=123 will be replaced by normalizePath, resulting in a transfer to https://localhost/app/foo.
This problem has been resolved in this commit.

Issue is here #1828

Thanks for the confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants