Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot Load Tasks In Subdirectory #28

Open
toksdotdev opened this issue Jun 26, 2019 · 6 comments · May be fixed by #34
Open

Cannot Load Tasks In Subdirectory #28

toksdotdev opened this issue Jun 26, 2019 · 6 comments · May be fixed by #34

Comments

@toksdotdev
Copy link

toksdotdev commented Jun 26, 2019

Due to the several Tasks that should execute to fulfill several aspects of our application, I desired a clean way of organizing our tasks.

In this light, decided to go with organizing similar tasks into subdirectories, only to discover that any task placed in a child directory/subdirectory(e.g. app/tasks/user/SendBirthdayWishes.js) aren't loaded into the scheduler.

Diving into the source code, I discovered that adonis-scheduler picks up only tasks placed directly(one-level down) in app/Tasks alone.

As a solution, we could get all the tasks placed in app/tasks/**/** recursively.

I could submit a PR for this if you desire.

Thanks.

@toksdotdev toksdotdev changed the title Cannot Read Tasks In Subdirectory Cannot Load Tasks In Subdirectory Jun 26, 2019
@olaoluwa-98
Copy link

@tnkemdilim A PR for this would be nice

@toksdotdev
Copy link
Author

I'm yet to get a go ahead from the library author.

@LeCoupa
Copy link

LeCoupa commented May 11, 2020

@nrempel Is this package still maintained? Do you need help?

@olaoluwa-98
Copy link

@nrempel, it will be really nice if someone could open a PR for this

@LeCoupa
Copy link

LeCoupa commented Jun 21, 2020

I think we should fork this, the author probably does not have the time to maintain it. @nrempel, can I take over this package please? :)

@toksdotdev toksdotdev linked a pull request Aug 24, 2020 that will close this issue
@LeCoupa
Copy link

LeCoupa commented Sep 28, 2020

The best alternative is to use this package: https://github.com/Rocketseat/adonis-bull

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants