Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle hashing shouldn't realize all paths in a directory tree simultaneously #75

Open
mlw opened this issue Oct 25, 2024 · 0 comments
Open

Comments

@mlw
Copy link
Contributor

mlw commented Oct 25, 2024

This is a minor issue that is only really a problem for large bundles (e.g. Xcode).

Currently, bundle hashing uses the subpathsOfDirectoryAtPath:error: API to get the list of files that need to be enumerated. This has some nice properties such as being able to know the count of files to process ahead of time. However the major drawback is that all paths must first be realized. For large bundles, such as Xcode, this can lead to a massive number of items (e.g. >140K).

We should instead consider the API enumeratorAtURL:includingPropertiesForKeys:options:errorHandler: to have better memory characteristics.

The major drawback with the new API is not knowing the number of files to process ahead of time which affects the progress bar status. This would have to be recomputed in a new way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant