Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

label_click and other interaction handlers should pass the event info #105

Open
RLesser opened this issue Jan 31, 2024 · 2 comments
Open

Comments

@RLesser
Copy link
Contributor

RLesser commented Jan 31, 2024

Currently the interaction handler only has the record data as available arguments. It should also have the Event spawned by the interaction. This will let us do different behaviors for shift.

@bmschmidt
Copy link
Collaborator

concretely, the minimal-impact way to handle this will be to take the SettableFunction class of this type:

  abstract default(datum: ArgType, plot: Scatterplot<Tiletype> | undefined): FuncType;

and convert them all to this type

  abstract default(datum: ArgType, plot: Scatterplot<Tiletype> | undefined, event : Event): FuncType;

...ensuring that all the handlers under the hood actually do pass their spawning events along the other two args.

@4nalog
Copy link

4nalog commented Feb 14, 2024

hey @bmschmidt,

Was looking to make my first contribution to the project. Can I take this up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants