Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build fails because of typescript errors #103

Open
preussi opened this issue Dec 18, 2023 · 5 comments
Open

npm run build fails because of typescript errors #103

preussi opened this issue Dec 18, 2023 · 5 comments

Comments

@preussi
Copy link

preussi commented Dec 18, 2023

I cannot build the module because the third compilation step fails due to errors in files:

Found 141 errors in 14 files.

Errors Files
1 node_modules/apache-arrow/util/buffer.d.ts:8
16 src/Aesthetic.ts:68
7 src/AestheticSet.ts:3
21 src/ColorAesthetic.ts:1
3 src/Dataset.ts:3
1 src/Image_Tile.ts:1
35 src/deepscatter.ts:3
12 src/interaction.ts:10
13 src/label_rendering.ts:46
17 src/regl_rendering.ts:8
3 src/rendering.ts:228
8 src/selection.ts:74
1 src/tile.ts:623
3 src/util.ts:16

Am I doing something wrong or is this associated with the version of typescript? I checked my version and it is 4.7.4.

@vzsolt1981
Copy link

vzsolt1981 commented Mar 27, 2024

As of today, by following the instructions, I'm getting the same build error as @preussi.

Any update on this?

@cceyda
Copy link

cceyda commented Jun 19, 2024

same here so I just used the version from cdn although it isn't the latest:
import Scatterplot from 'https://cdn.jsdelivr.net/npm/[email protected]/+esm'

@cceyda
Copy link

cceyda commented Jun 20, 2024

I would really like a solution to the build problems though
because I want to use arrow_table but it is giving
Vector constructor expects an Array of Data instances error when run with 2.15.2 and only works from source

@cceyda
Copy link

cceyda commented Jun 22, 2024

Ok I was able to build using the commented out vite.config instead.
(comment out the code before that line and uncomment the commented code)

/* Our friend in Northern VA advises this to remove Arrow:

@kungfooman
Copy link

Suggestion: Convert to pure JavaScript / ESM with a jsconfig including the {checkJs: true} option and don't waste time on such TS errors anymore... you will be able to load the library via import map - completely build free, allowing quick PR testing aswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants