Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page about procedure to follow to patch old releases #2398

Open
maxulysse opened this issue Mar 20, 2024 · 2 comments
Open

Add a page about procedure to follow to patch old releases #2398

maxulysse opened this issue Mar 20, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@maxulysse
Copy link
Member

let's say you need to patch pipeline 1.0 because that's the one in prod, so you want to patch it.
I'd create a 1.0 branch based on the 1.0 release, make a PR which fix the bug, if said bug still exists in dev, make a PR to dev to fix it too.
If necessary pin nf-core tools to ensure linting works.
Merge PRs and release from the 1.0 branch with a 1.0.fix.0 tag.
If another patch need to happen on this patched release, then continue working on said 1.0 branch, and do a 1.0.fix.1 tag

I think that we should only accept bugfixes for patch releases if the bugfix also goes into dev. I think that it needs to be applied twice, no way around that. (except if the bugfix is already in dev or no longer relevant)

@maxulysse maxulysse added the enhancement New feature or request label Mar 20, 2024
@maxulysse maxulysse self-assigned this Mar 20, 2024
@ewels
Copy link
Member

ewels commented Mar 20, 2024

I would suggest we follow semver, not sure we need fix stuff? eg. this would be fine in chronological order:

  • 1.0.0
  • 1.1.0
  • 1.2.0
  • 1.0.1
  • 1.3.0
  • 1.0.2
  • 1.4.0
  • 1.4.1
    ..etc

⚠️ Need to make sure that the website understands semver ordering before we do this for real

@mashehu
Copy link
Contributor

mashehu commented Mar 22, 2024

website should already understand that 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants