Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional downstream processes written in DSL1 -- UPGRADE now to DSL2 #283

Open
Jani-94 opened this issue Dec 6, 2022 · 2 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Jani-94
Copy link

Jani-94 commented Dec 6, 2022

Description of feature

Already forked from methylseq (written in DSL1) and added the following:

  1. additional methylation calling with cgmaptools and general statistics (plots and tables) using cgmaptools.
  2. coverage stats and other things using methylkit.
  3. Create a plot of methylation levels across the TSS using viewBS.
  4. Input a bam file and continue from there with methylation calling etc.

Will start to update code from DSL1 to DSL2.

Cloned & modified Github: https://github.com/FAANG/GSM-pipeline

@Jani-94 Jani-94 added the enhancement New feature or request label Dec 6, 2022
@ewels
Copy link
Member

ewels commented Dec 15, 2022

Excited to see some of these improvements! I would definitely split them up rather than trying to tackle all at once. As such, it might be worth making a new issue for each.

For each addition, you'll need to:

  • Check that the software is packaged in bioconda (and add it if not)
  • Add a new DSL2 module to nf-core/modules (see tutorial and docs)
  • Once that's approved and merged, open a pull-request against the dev branch of this repository to add the new module
    • Run nf-core modules install [your-new-tool]
    • Add the import statement and wire up the channels

I'd recommend starting with the simplest, once you've gone through the process once or twice it starts getting a lot easier..

Shout on Slack if you need any help with any of this!

@sateeshperi
Copy link
Contributor

hey @Jani-94 are there any updates for what you proposed here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants