Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate conversions with new files #95

Open
HildeLa opened this issue Dec 17, 2024 · 4 comments
Open

Calculate conversions with new files #95

HildeLa opened this issue Dec 17, 2024 · 4 comments

Comments

@HildeLa
Copy link

HildeLa commented Dec 17, 2024

Hi, could you help us handling the change in the output files?

In the updated workflow the saved files are different, and include OnixHarp files. The OnixDigital files are also changed and can no longer be read with the methods that were given here:
https://github.com/neurogears/vestibular-vr/blob/main/analysis/photometry_sync_example.ipynb

Now theres a need to clarify what should be aligned to what. It seems the issue is in aligning onix to harp, and not in aligning photometry to onix.
The issue appears in this function: https://github.com/ikharitonov/vestibular_vr_pipeline/blob/5ef5a28536ab57840f11d58c4a9333836a8f29d8/harp_resources/process.py#L267

Probably, a change is needed what files and timestamps should be used when defining conversion functions.

If it is possible, the ideal would be to get a new example of how the onix and harp data can be aligned with the new files and file structures.

For reference, I'll add some relevant files from an example recording:
OnixDigital_1904-01-14T18-00-00.csv
OnixDigital_1904-01-14T19-00-00.csv
OnixHarp_1904-01-14T18-00-00.csv
OnixHarp_1904-01-14T19-00-00.csv
Events.csv

@RoboDoig
Copy link
Collaborator

RoboDoig commented Dec 18, 2024

@HildeLa - I think the main change is that there is a separate file (OnixHarp) that links HARP time to ONIX time, but potentially some other changes happened that I didn't account for.

I think the easiest thing is if you send me (or just point me to a datafolder) a full example dataset for a recent session and I will update the photometry sync example notebook.

@EleonoraAmbrad
Copy link
Collaborator

EleonoraAmbrad commented Dec 19, 2024

thanks! I will share a file with you tomorrow, do you also need the fiberphotometry?

@RoboDoig
Copy link
Collaborator

Yes if possible, would be good to debug everything at once

@EleonoraAmbrad
Copy link
Collaborator

EleonoraAmbrad commented Dec 22, 2024

I just sent you an email with a link to the drive folder where you can find the data, thank you for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants