Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enh]: Extend signature of supported methods #742

Open
FBruzzesi opened this issue Aug 8, 2024 · 1 comment
Open

[Enh]: Extend signature of supported methods #742

FBruzzesi opened this issue Aug 8, 2024 · 1 comment

Comments

@FBruzzesi
Copy link
Member

FBruzzesi commented Aug 8, 2024

We would like to learn about your use case. For example, if this feature is needed to adopt Narwhals in an open source project, could you please enter the link to it below?

No response

Please describe the purpose of the new feature or describe the problem to solve.

There are some methods for which we have partial support, meaning that not the full polars api is supported.

However this should be possible for some methods and/or some arguments (examples below)

Suggest a solution if possible.

No response

If you have tried alternatives, please describe them below.

No response

Additional information that may help us understand your needs.

Here a (partial) list of methods and arguments missing:

method missing argument(s) note
DataFrame.drop strict ✅ Fixed in #773
DataFrame.drop_nulls subset ✅ Fixed in #779
DataFrame.get_column default It possibly depends on #754
DataFrame.join suffix
DataFrame.join_asof suffix, tolerance
@MarcoGorelli
Copy link
Member

cool, happy to expand where it makes sense - if it's possible to get support across pandas/polars/pyarrow then it's probably already worth doing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants