System theme does not work

[simoniz0r]

System:

• Nheko commit/version: Latest AppImage release as of 11-25-2017 Latest AppImage and RPM build as of 12/26/17
• Operating System: Xubuntu 16.04, Ubuntu 18.04 daily with LXQt, and openSUSE Tumbleweed
• Qt version: 5.5.1 on 16.04? (not sure which version) and 5.9.3 on 18.04 and Tumbleweed
• C++ compiler: N/A
• Desktop Environment: Xfce and LXQt

Actual behavior

System theme does nothing. Dark theme contains white space below the channel list

Expected behavior

System theme should follow the colors of my system. Dark theme should not have white space bellow the channel list

Steps to reproduce

Try to use the system theme ~~~and dark theme in the AppImage release.~~

Also, not sure if this is a bug, but nheko must be restarted before the theme will change.

Screenshot of the dark theme with white space under the channel list:

image

Screenshot of the system theme not following system colors:

:EDIT: Dark theme and theme loading issues fixed; updated comment to cross these issues out.

[mujx]

It might be an issue with the theme you're using if the system option has no effect. I will investigate some more.

[simoniz0r]

I'm using KDE's release of Breeze dark for GTK on both systems, but using other themes doesn't seem to work either. I just tried a half dozen different themes with no effect. Other Qt based apps are themed fine on both systems.

:EDIT: The latest AppImage fixes the problems with the white space below the channel list and needing to restart to change themes 👍

[simoniz0r]

Seems like there's a discusson going on over here about this... might be some useful info for you there. probonopd/linuxdeployqt/issues/60

[simoniz0r]

I just wanted to confirm that this is actually only an issue with the AppImage release. I was able to get the rpm build from Fedora's copr to install with a little extra work, and the system theme option does work when installed using the rpm.

[mujx]

@simoniz0r Good to know. What do you mean by 'extra work'? Do you have any more info so we can adjust the AppImage?

[simoniz0r]

It was just a dependency issue because I was using an rpm that was built for Fedora. I had to make a symlink for a lib that was named differently on OpenSUSE than it was on Fedora. Nothing to do with the AppImage build AFAIK.

[simoniz0r]

I just installed the RPM build from the releases page here on openSUSE Tumbleweed, and the system theme is not working with the RPM release either. This is kind of strange as it was working with the RPM release that was made for Fedora from Fedora's copr.

[mujx]

The rpm on github releases just uses the AppImage (it has no dependencies), so it's still a problem with the AppImage.

I wonder if building the AppImage on the target system will fix the issue. Could you run the .ci/linux/deploy.sh script that builds the AppImage on your system?

[simoniz0r]

Could you run the .ci/linux/deploy.sh script that builds the AppImage on your system?

Sorry, I don't have the necessary packages for building nheko or the AppImage of nheko installed on this system. Installing qmake is another 141 packages for me lol

[ghost]

I installed nheko-git from the AUR on manjaro running gnome, system theme doesn't work for me either.

[PureTryOut]

@simoniz0r note that for me Breeze Dark (set as both Qt and GTK theme) works right now with the latest AppImage. Could you try the nightly again?

[simoniz0r]

Nope, no dice. nheko is either missing some deps for this to work or it needs to be compiled on a different platform for this to work.

[mujx]

@simoniz0r Can you point us to an AppImage that works with the system's theme? Seems weird that works for @PureTryOut, maybe he has some extra libraries installed?

[simoniz0r]

The only one I can think of that follows my system theme that doesn't provide an option to use the GTK theme would be the VLC AppImage.

[unclechu]

I can say it was working before, nheko was colored exactly as my system theme, I have configured both QT4 and QT5 for using GTK theme (which is Adwaita-dark) or Adwaita-dark for QT5 (because in qt5ct there's no option for using GTK theme) but it looks like nheko ignores it.

[unclechu]

I also have had correctly colored file dialog with system theme, it was all dark, as it supposed to be with Adwaita-dark, but with "Dark" theme of nheko gets me something strange (@mujx is it supposed to be reported as separated issue?):

[simoniz0r]

because in qt5ct there's no option for using GTK theme

offtopic, but there is; it's the GTK Qt Platformtheme plugin. The name differs quite a bit from distro to distro.

[unclechu]

@simoniz0r Thanks for notice but I can't find anything for QT5 in Fedora 28 that would looks like this. Anyway, choosing Adwaita-dark theme works well for most applications (except nheko but used to work few releases ago).

[unclechu]

UPDATE I realized in my case system theme wasn't working because I've been using nheko RPM package from github which is (as a DEB one) just a wrapper for AppImage one, and AppImage encapsulates stuff and doesn't use system theme. So now in Fedora 28 Workstation I installed nheko 0.4.0 from fedora-updates repo and everything is working properly now, system colors, correct file dialog appearance (as anywhere else in my system) and custom font family I set in my qt config.

[unclechu]

@simoniz0r I see it probably related to your case too, because you too use AppImage. I'm not very familiar with AppImage but it may be not the nheko's issue.

[simoniz0r]

Yeah, the rpm from Fedora's copr works fine for me with the system theme, but there's a lib or two that don't match up, so I have to make symlinks for nheko to work.

When I get some time, I'll try to steal the spec file from the copr build and see if I can't move it over to the openSUSE Build Service and set it up for openSUSE deps.