Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON support optional #216

Closed
wants to merge 2,226 commits into from
Closed

Conversation

bog-dan-ro
Copy link

@bog-dan-ro bog-dan-ro commented Sep 13, 2022

Close #215

@msteinbeck
Copy link
Owner

Hi @bog-dan-ro,

thank you for your contributions. I would like to avoid adding new compilation options to TinySpline because this makes it necessary to test more combinations of options. Moreover, if JSON serialization is disabled, certain tests must also be disabled. Rather than conditionally include/exclude features, I would prefer to rename the affected functions. In the long run, I would like to replace parson with a custom implementation anyways (I full fledged JSON library is not needed to write splines as JSON; parsing might be more difficult though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parson conflicts with json-c library
5 participants