Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use testconfig in hack/test script #96

Open
crazy-max opened this issue Sep 16, 2024 · 0 comments
Open

use testconfig in hack/test script #96

crazy-max opened this issue Sep 16, 2024 · 0 comments
Labels
kind/enhancement New feature or request

Comments

@crazy-max
Copy link
Member

crazy-max commented Sep 16, 2024

https://github.com/moby/buildkit-bench/blob/5593f8d7f160ae17a5462bee02af395f905e4355/hack/test runs benchmarks with default values that might not be suitable with testconfig: https://github.com/moby/buildkit-bench/blob/master/testconfig.yml

This script should use the testconfig if bench regexp, count and time are not set so it runs like ci.

@crazy-max crazy-max added the kind/enhancement New feature or request label Sep 16, 2024
@crazy-max crazy-max changed the title use testconfig with hack/test script use testconfig in hack/test script Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant