Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle and report errors #120

Open
crazy-max opened this issue Sep 19, 2024 · 1 comment
Open

handle and report errors #120

crazy-max opened this issue Sep 19, 2024 · 1 comment
Labels
kind/enhancement New feature or request

Comments

@crazy-max
Copy link
Member

Currently when a benchmark or test fails, the workflow just error out and doesn't report anything: https://github.com/moby/buildkit-bench/actions/runs/10938717148/job/30367598076

--- FAIL: BenchmarkBuild/BenchmarkBuildHighParallelization256x/ref=v0.11.0/run=3
    run.go:255: 
        	Error Trace:	/src/util/testutil/run.go:255
        	            				/src/util/testutil/run.go:256
        	            				/src/test/build_test.go:22
        	Error:      	Should be true
        	Test:       	BenchmarkBuild
--- FAIL: BenchmarkBuild
FAIL
exit status 1
FAIL	github.com/moby/buildkit-bench/test	1528.528s

It should instead continue, report the error and mark failure on the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants
@crazy-max and others