-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pop-up does not show video controls on large screens #1776
Comments
Users are unable to scroll down the page to see the controls, is that right, @Muhammed-Moinuddin? |
I can try solving this issue @leecalcote @Muhammed-Moinuddin |
You would have been right if pop-up were a part of the screen. But it's not like that, screen is separate from pop-up and is scrollable so we just need to make pop-up a bit responsive for the large screens. |
Perfect.webmThank you for your work on this issue. However, after reviewing your fix, I found that the original functionality was perfectly fine, and the video controls were visible as intended. Therefore, I don't believe this is a valid issue. Could you please double-check from your side? |
@Muhammed-Moinuddin Also, in the future, could you please wait for assignment or confirmation before starting work on an issue? |
It is valid issue, the browser makes it like scrollable but it is not and video controls are hiding due to it. We'll discuss this in upcoming meeting. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
On page https://meshery.io/catalog , after clicking import any catalog item link there is a pop-up containing video tutorial. So on large screen the video controls are not visible.
Expected Behavior
The pop-up needs to be responsive on large screens, so it shows video controls.
Screenshots
On large screens
On normal screens
I would like to work on it.
Enviroment:
Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the
master
branch.The text was updated successfully, but these errors were encountered: