Update supportedLocales, improvements of Chinese #795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
English is not my native language; please excuse typing errors.
This config only use zh and zh-Hant in supportedLocales:
Infact, the relationships of Chinese are like below:
The first problem of this config is, 繁體中文 - Chinese (Traditional) is mainly used in Taiwan, Hong Kong and Macau, so I think regional of zh-Hant should be better changed to zh-TW.
The second problem is, currently most browsers only use zh-CN, zh-TW, zh-HK in the "Accept-Language" field.
Here are two screenshoots:
This screenshot is from Chrome, I will translate the options line by line as below:
Firefox provides us with more opinion, I will also translate the options line by line as below:
Besides, the Laravel Lang project provides Chinese translation in zh-CN, zh-TW and zh-HK. When I use your project for the first time, the Accept-Language of my browser are
zh-CN,zh;q=0.8,zh-TW;q=0.7,zh-HK;q=0.5,en-US;q=0.3,en;q=0.2
, but the localized URL returned zh and shown English, which confused me a lot.So, I think it's better to add zh-CN, zh-TW and zh-HK, with zh-SG and zh-MY which are listed in zh.wikipedia.org by the way. And for those who do not want to maintain the regional language, it's also necessray to keep zh-Hans and zh-Hant.