Middleware\LocaleSessionRedirect can't handle request url from proxy server , cause https to http

[spawnash]

Describe the bug
i'm using reverse proxy server to handle ssl and load balance
this middleware Mcamara\LaravelLocalization\Middleware\LocaleSessionRedirect will handle the url with locale prefix,
but at line:51 it will parse url from https to http , i guess the reason is this func parse url from load balance request url not client request url

To Reproduce
Steps to reproduce the behavior:

1. i'm using valet share to reproduce
2. visit a route without locale prefix
3. die dump the handled url($redirection) which middleware dose
4. See error
   

Expected behavior
return correct url

More info:

• Version of Laravel :5.8
• Version of the Laravel-localization package:1.3.2
• Which middleware is used in Route::groups: Mcamara\LaravelLocalization\Middleware\LocaleSessionRedirect

[dsqwared5]

Describe the bug i'm using reverse proxy server to handle ssl and load balance this middleware Mcamara\LaravelLocalization\Middleware\LocaleSessionRedirect will handle the url with locale prefix, but at line:51 it will parse url from https to http , i guess the reason is this func parse url from load balance request url not client request url
...
hi, did you fixed it? I have the same issue

[tominal]

Oh wow this is a significantly older issue and I'm encountering it in a multi-tenancy setup in 2024.

This will always occur when a load balancer sends traffic in HTTP instead of HTTPS. I'm not sure what the fix here would be beyond adding a new flag to this repository's config file that forces HTTPS all the time. Actually, if we configure our ALB to forward traffic to an EC2 using HTTPS, then that should take care of this issue.

[iwasherefirst2]

Hi everyone,

Thanks for bringing this up! I’m interested in helping with this issue, but I’m unsure how to reproduce it locally. If someone could write a failing test case and create a PR, that would be super helpful. It would give me a clearer understanding of the problem and make it easier to contribute effectively.

[tominal]

If someone could write a failing test case and create a PR, that would be super helpful. It would give me a clearer understanding of the problem and make it easier to contribute effectively.

I bet all we'll need to do is have a test case for an HTTPS URL here and it'll try to redirect to HTTP.

laravel-localization/tests/LaravelLocalizationTest.php

Line 11 in af5b239

protected const TEST_URL = 'http://localhost/';

If someone doesn't beat me to it I can poke at it later!