Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access to all files in order to read/write repos from external storage #616

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

prattpratt
Copy link
Contributor

I completely can not use import external repos on my device running Android 12 (API 31). Access all files is required.

@prattpratt prattpratt force-pushed the feature/access-all-files branch from 985bd15 to 51f58f3 Compare April 4, 2022 07:36
@maks
Copy link
Owner

maks commented Apr 4, 2022

Thank you very much for contributing this!
This all looks good. 👍🏻
I'l test this out and likely merge it asap.

@maks
Copy link
Owner

maks commented Apr 4, 2022

LGTM. Thanks again for contributing this.

@maks maks merged commit 28e7cac into maks:master Apr 4, 2022
@maks
Copy link
Owner

maks commented Apr 4, 2022

This is now available in the Beta channel of MGit on Google Play.
Fixes: #465 #610

@maks
Copy link
Owner

maks commented Apr 4, 2022

Actually the use of the permission is causing issues with the Google Play review of the new release so it's not yet available as I need to try to contact Google Play staff about this.

@prattpratt
Copy link
Contributor Author

prattpratt commented Apr 4, 2022

@maks Thanks for quick PR merge.
I think that we need add one more request to access all files permission in settings when importing SSH keys.
I will prepare a new PR today.

@prattpratt
Copy link
Contributor Author

prattpratt commented Apr 4, 2022

I've added a new PR #617.

@cognifloyd
Copy link

I joined the beta, but I don't see the update. Is Google play blocking it from hitting the beta channel too?

@maks
Copy link
Owner

maks commented Apr 22, 2022

@cognifloyd yes per #620 unfortunately until Google allows MGit to use the "all files" permission, this update cannot be published, even on the beta channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants