Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Convenience methods? #5

Open
lukeed opened this issue Jul 9, 2017 · 8 comments
Open

Additional Convenience methods? #5

lukeed opened this issue Jul 9, 2017 · 8 comments
Labels

Comments

@lukeed
Copy link
Owner

lukeed commented Jul 9, 2017

Look thru other collections, see if there are methods that can be greatly improved... perhaps pluck?

Would be adding to existing convenience methods: unique, flatten

@lukeed lukeed added the maybe label Jul 9, 2017
@lukeed lukeed modified the milestone: 1.0.0 Jul 9, 2017
@thangngoc89
Copy link

As per your README, you're providing Array.prototype fast alternative. Goal changed?

@lukeed
Copy link
Owner Author

lukeed commented Jul 9, 2017

Not sure if I understand what you mean?

I'm still doing prototype methods. But I also have some additional "helper" methods. For now, I have unique and flatten because they're faster than alternatives. This issue is to potentially add more helpers.

@thangngoc89
Copy link

Ah Ok. Some high performance helpers out of the box is great for DX

@lukeed
Copy link
Owner Author

lukeed commented Jul 9, 2017

Yeah, I think so! Primary focus is on the prototype methods, but some extras won't hurt 😉

Disclosure: Not sure if you saw, but most of these methods are only faster than native on Node 6 and below. I'm waiting until I return to my main machine before releasing official metrics.

@thangngoc89
Copy link

Yes, I saw the bench and your mentions. I always bench everything before introducing it to my application. For instance: map is actually faster on Node 8

@lukeed
Copy link
Owner Author

lukeed commented Jul 9, 2017

Yup! That's fine with me too. Would much rather rely on natives, but not ideal for browsers and older node versions.

@developit
Copy link

pluck would be nice.

@lukeed
Copy link
Owner Author

lukeed commented Apr 18, 2018

Object pluck? I was planning on doing a similar set of modules for objects methods. Can't remember if I have the npm org already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants