Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colorize units in the rest of the client #1269

Open
daavko opened this issue Aug 14, 2022 · 0 comments · May be fixed by #1276
Open

Colorize units in the rest of the client #1269

daavko opened this issue Aug 14, 2022 · 0 comments · May be fixed by #1276
Assignees
@lmoureaux
Labels
enhancement New feature or request gui This issue requires changes to the user interface

Comments

@daavko
Copy link
Collaborator

daavko commented Aug 14, 2022

Is your feature request related to a problem? Please describe.
Currently, units in Research view, City view (when choosing what to produce), Units widget, and Help (both in the list and in the unit detail) aren't colorized.

Describe the solution you'd like
I'd like them to be colorized like they are in Map view. I think it's fine to use the current player's color for all of those.

Describe alternatives you've considered
Not colorizing them, which would look very ugly

Additional context
No additional context
@daavko daavko added enhancement New feature or request Untriaged This issue or PR needs triaging labels Aug 14, 2022
@lmoureaux lmoureaux self-assigned this Aug 15, 2022
@lmoureaux lmoureaux added gui This issue requires changes to the user interface and removed Untriaged This issue or PR needs triaging labels Aug 15, 2022
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 15, 2022
@lmoureaux
Use hue replacement anywhere a unit sprite is needed
b7750a8 
The use of client_player() triggers hundreds of assertions when loading a large
game as a global observer; we'll need to fix that.

Closes longturn#1269.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Aug 15, 2022
@lmoureaux
Use hue replacement anywhere a unit sprite is needed
21b0362 
The use of client_player() triggers hundreds of assertions when loading a large
game as a global observer; we'll need to fix that.

Closes longturn#1269.
@lmoureaux lmoureaux linked a pull request Aug 15, 2022 that will close this issue
Draft
@jwrober jwrober mentioned this issue Sep 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lmoureaux lmoureaux

Labels
enhancement New feature or request gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use hue replacement anywhere a unit sprite is needed lmoureaux/freeciv21
2 participants
@daavko @lmoureaux