Vcluster secrets labelling is missing

[irizzant]

What happened?

Vcluster secrets are created without any labels

What did you expect to happen?

Vcluster to add labels to identify secrets

How can we reproduce it (as minimally and precisely as possible)?

Just create a vcluster

Anything else we need to know?

No response

Host cluster Kubernetes version

$ kubectl version
# paste output here

Client Version: v1.31.2
Kustomize Version: v5.4.2
Server Version: v1.31.2-eks-7f9249a

vcluster version

$ vcluster --version
# paste output here

vcluster version 0.20.4

VCluster Config

# My vcluster.yaml / values.yaml here

[maheshbaliga]

Hi @irizzant. Could you share more details about the issue/enhancement? Info like expected vs. actual behaviour, errors, or steps to reproduce would help.

[irizzant]

Hi @maheshbaliga , when you create vclusters in a namespace there are some secrets created.

E.g. for a vcluster called example you have a secret called vc-example-vcluster containing the admin kubeconfig.

That secret does not have any metadata.labels applied to it thus making it difficult to choose among other kubernetes secrets in the same namespace.

There should be a label added to those secrets in metadata.labels, something like
vcluster=name of the vcluster
vcluster-kubeconfig=true

to help identify and chose those secrets in a kubernetes style without using the secret name

[maheshbaliga]

Thanks @irizzant for providing the additional details about the issue. I was able to replicate the scenario based on the information you shared. I’ll raise a PR shortly to propose a fix; let’s wait for the maintainers to then review it.