Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine .env URLs #1111

Open
YoungjaeKim opened this issue Dec 11, 2024 Discussed in #1110 · 0 comments
Open

refine .env URLs #1111

YoungjaeKim opened this issue Dec 11, 2024 Discussed in #1110 · 0 comments

Comments

@YoungjaeKim
Copy link
Contributor

YoungjaeKim commented Dec 11, 2024

AS-IS

  1. API
BASE_URL=http://localhost:3000 # default: http://localhost:3000
# APP_PORT=4000 # default: 4000
  1. WEB
NEXT_PUBLIC_API_BASE_URL=http://localhost:4000
API_BASE_URL=http://127.0.0.1:3000
NEXT_PUBLIC_MAX_DAYS=90

TO-BE

Objective; (1) clearly define which variable is for API backend or WEB frontend. (2) Remove NEXT_ prefix because our user doesn't consider what NEXT is.

  1. API
WEB_BASE_URL=http://localhost:3000
# API_BASE_PORT=4000 # default: 4000
  1. WEB
API_BASE_URL=http://localhost:4000
WEB_BASE_URL=http://127.0.0.1:3000
QUERY_MAX_TIMESPAN=90

This could break user experience because environment variables should be changed.

Additional information

It is related to issue #232

@YoungjaeKim YoungjaeKim changed the title redefine .env URLs refine .env URLs Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant