Batch.use improvement

[hpn33]

way dont use like this

inline fun <T : Batch> T.use(func: T.() -> Unit) {
    begin()
    func()
    end()
}

and on using

batch.use {
    draw(something, 0, 0)
// or
    player.draw(this)
}

[czyzby]

I'm not sure what you mean. This utility is already available in ktx-graphics.

[hpn33]

i say change that

//me
inline fun <T : Batch> T.use(func: T.() -> Unit) {
    begin()
    func() // <--
    end()
}

//you
inline fun <B : Batch> B.use(action: (B) -> Unit) {
  begin()
  action(this) // <--
  end()
}

on using

// you
batch.use { it ->
   it.draw(somthing, 0, 0)
   it.draw(somthing, 0, 0)
   it.draw(somthing, 0, 0)

   player.draw(it)
   obj.draw(it)
}

//me
batch.use { it ->
  draw(somthing, 0, 0)
  draw(somthing, 0, 0)
  draw(somthing, 0, 0)

  player.draw(this)
  obj.draw(this)
}

I do not want to do a job twice

it`s just little better

[hpn33]

@czyzby

[czyzby]

That's deliberate, as you usually don't want to overshadow this when drawing stuff and you have the reference to the original batch you called use on. I'm usually very careful about using T.() extension methods, as they make it hard to reason about the scope of the block. So, the expected usage looks more like this:

batch.use {
   batch.draw(something, 0, 0)
   batch.draw(something, 0, 0)
   batch.draw(something, 0, 0)

   player.draw(batch)
   obj.draw(batch)
}

Besides, the original use method from stdlib has the same signature.