Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline styles #950

Open
tdelmas opened this issue Feb 15, 2020 · 1 comment
Open

Remove inline styles #950

tdelmas opened this issue Feb 15, 2020 · 1 comment
Labels
bug

Comments

@tdelmas
Copy link
Collaborator

tdelmas commented Feb 15, 2020

Inline style should be moved into scss files.

It will also help #757

Once this is done, the CSP policy could probably be updated to remove unsafe-inline for style-src.

⚠️ For svg, CSP and Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1262842 : https://pokeinthe.io/2016/04/09/black-icons-with-svg-and-csp/
tdelmas referenced this issue Feb 15, 2020
Fix deprecated/invalid html (#940)
d07d701 
* Fix anchors

* Remove useless type="text/javascript" on script tag

* Add space to avoid proken paragraph

* Mardown adds a paragraph around that html, including the script is there is no \n betwenn them, and it's not valid html.

* table is not allowed inside p

* replace deprecated frameborder="0" by style="border: none;"

* replace deprecated border="1" by style="border:1px"

* remove invalid border="0" on input type image

* attr width is not valid on a div

* center is not a valid value for style float.
@tdelmas
Copy link
Collaborator Author

tdelmas commented Feb 18, 2020

Also, for CSP, Plotly may be a problem: plotly/plotly.js#2355

@bdaehlie bdaehlie added the bug label Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bdaehlie @tdelmas