Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abandon coffeescript in favor of ES6 #255

Open
VanTanev opened this issue Sep 27, 2018 · 5 comments
Open

Abandon coffeescript in favor of ES6 #255

VanTanev opened this issue Sep 27, 2018 · 5 comments
Assignees
Milestone

Comments

@VanTanev
Copy link
Collaborator

VanTanev commented Sep 27, 2018

I propose rewriting the module in ES6 for version 2.0
Honestly, dealing with coffee script is a bigger distraction than it's worth.

@VanTanev VanTanev added this to the 2.0.0 milestone Sep 27, 2018
@VanTanev VanTanev self-assigned this Sep 27, 2018
@leocaseiro
Copy link
Owner

I totally agree. IMO I never really liked coffeescript. It was more just a challenge.

Happy to use es6 or TS. But TS will be confused with Angular 2-6

@andresgardiol
Copy link

It would be great to be able to use chosen with es6 modules.
Will you rewrite it by chance?

@VanTanev
Copy link
Collaborator Author

@andresgardiol angular-chosen is separate from chosen-js. Even if we rewrote angular-chosen to be compatible with what you mean to be (I assume) browser es6 modules, chosen-js itself is not, and we cannot rewrite it.

However, even the current version of both angular-chosen and chosen-js are compatible with es6 imports, as handled by WebPack.

@andresgardiol
Copy link

Thanks for your answer. Can you tell me how you import angular-chosen module with es6? I had some problems to do so.

@VanTanev
Copy link
Collaborator Author

This really isn't the place, but 1 short example

import 'jquery'
import 'chosen-js'
import 'angular-chosen-localytics'
import angular from 'angular'

angular.module('app', ['localytics.directives'])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants