Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now that the hostprocess container is stabilizing, can we abandon CSI proxy? #342

Open
IndCheung opened this issue May 15, 2024 · 4 comments

Comments

@IndCheung
Copy link

As the question suggests, can we abandon csi proxy and run csi plugin directly in hostprocess mode?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 12, 2024
@mauriciopoppe
Copy link
Member

/remove-lifecycle rotten

CSI Proxy is a library of functions that are useful for CSI Drivers implementors who want to support Windows in their CSI Driver. The initial CSI Proxy design addressed the limitations about not being able to run privileged Pods in Windows with a client-server model, to do so, CSI Proxy is set up during the node bootstrap process and on its startup it creates named pipes in the host for CSI Drivers to use it, then the CSI Driver node plugin (usually the CSI Driver node DaemonSet) would have code to connect to the named pipes. Later, whenever it came time to do any privileged storage operations the CSI Driver node plugin would make an RPC call to the binary through the named piped.

After HostProcess containers, the CSI Driver node plugin can run the privileged operation on its own and doesn't need an extra binary (CSI Proxy) to do the calls, however CSI Proxy as mentioned before is a library of useful functions for CSI Drivers, therefore, CSI Proxy v2 will change the way it works moving from a client/server model to being a go library. With this in mind, CSI Proxy won't be abandoned.

The implementation is already complete in https://github.com/kubernetes-csi/csi-proxy/tree/library-development, we haven't reached the graduation criteria mentioned in kubernetes/enhancements#3636 yet as we haven't seen many CSI Drivers adopt this new model.

As the question suggests, can we abandon csi proxy and run csi plugin directly in hostprocess mode?

Sure, you can copy the functions from the CSI Proxy codebase in your CSI Driver and that'd work just fine. CSI Proxy would still live as a common library that CSI Drivers could use.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 10, 2024
@IndCheung
Copy link
Author

IndCheung commented Oct 10, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants