Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove screenshot from repo #153

Closed
clason opened this issue Nov 18, 2022 · 2 comments · Fixed by #154
Closed

Remove screenshot from repo #153

clason opened this issue Nov 18, 2022 · 2 comments · Fixed by #154

Comments

@clason
Copy link
Contributor

clason commented Nov 18, 2022

As this repository is meant to (among other things) being cloned as a Neovim plugin, having the 1Mb screenshot under version control is wasteful.

Instead, it is better practice to upload the screenshot to Github's user content server (by dragging it into the rich text editor when editing the README); then it can be removed from the repo.

If that is acceptable, I can make a PR for that.
@kkharji
Copy link
Owner

kkharji commented Nov 18, 2022

Hey @clason, It would be great. I'm unaware of github user content server

@clason clason mentioned this issue Nov 18, 2022
Merged
@clason
Copy link
Contributor Author

clason commented Nov 18, 2022

done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: remove screenshot from repo
2 participants
@clason @kkharji