Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a GCP Dataform subplugin #458

Open
anna-geller opened this issue Oct 15, 2023 · 4 comments
Open

Add a GCP Dataform subplugin #458

anna-geller opened this issue Oct 15, 2023 · 4 comments
Assignees
Labels
area/plugin Plugin-related issue or feature request enhancement New feature or request good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

anna-geller commented Oct 15, 2023

Problem

We already support the open-source edition of Dataform: https://github.com/kestra-io/plugin-dataform

However, our users requested the ability to trigger Dataform jobs running on GCP Dataform service https://cloud.google.com/dataform?hl=en

API

The OSS version was implemented as a Node.js-CLI plugin. However, the GCP-specific plugin will likely only need to talk to GCP Dataform service via the REST API https://cloud.google.com/dataform/reference/rest

Specifically, the workflow invocation seems like the right endpoint https://cloud.google.com/dataform/reference/rest#rest-resource:-v1beta1.projects.locations.repositories.workflowinvocations

Possible syntax

id: dataform
namespace: dev
tasks:
    - id: transform
      type: io.kestra.plugin.gcp.dataform.InvokeWorkflow
      wait: true # wait for results by default so that if that job fails, this task fails as well
      # other properties from this request body https://cloud.google.com/dataform/reference/rest/v1beta1/projects.locations.repositories.workflowInvocations#WorkflowInvocation 

ideally, we should combine this with the list/get/query endpoints to allow polling for workflow invocation's results (wait: true)

@anna-geller anna-geller added the enhancement New feature or request label Oct 15, 2023
@drelum
Copy link

drelum commented Oct 16, 2023

Support for GCP Dataform service would be very useful.

@anna-geller anna-geller changed the title Add a Dataform plugin Add a GCP Dataform plugin Oct 30, 2023
@anna-geller anna-geller changed the title Add a GCP Dataform plugin Add a Dataform plugin Nov 3, 2023
@anna-geller
Copy link
Member Author

for now done, we'll keep the issue open only to add GCP implementation

@anna-geller anna-geller changed the title Add a Dataform plugin Add a GCP Dataform subplugin Nov 6, 2023
@anna-geller anna-geller added this to the v0.17.0 milestone Jan 15, 2024
@anna-geller anna-geller removed this from the v0.17.0 milestone Apr 15, 2024
@anna-geller anna-geller added the area/plugin Plugin-related issue or feature request label Jun 12, 2024
@tchiotludo tchiotludo added the good first issue Great issue for new contributors label Oct 1, 2024
@Ben8t
Copy link
Member

Ben8t commented Nov 5, 2024

fyi, moving this one up in the prioritization as the issue got several upvotes 👍
will discuss with Mat if better to move to gcp or dataform repo

@anna-geller
Copy link
Member Author

yup totally, seems also a fairly quick one

@Ben8t Ben8t transferred this issue from kestra-io/kestra Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/plugin Plugin-related issue or feature request enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: Backlog
Status: Planned
Development

No branches or pull requests

6 participants