Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new right sidebar is not included in translations (Open an issue, Get a demo etc) #6451

Open
anna-geller opened this issue Dec 13, 2024 · 8 comments
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

Describe the issue

Example for Japanese:
image

Environment

  • Kestra Version: develop
@anna-geller anna-geller added bug Something isn't working area/frontend Needs frontend code changes labels Dec 13, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 13, 2024
@MilosPaunovic
Copy link
Member

Nope, and that is like that by design (or at least, the current one), see the prompt there

prompt = f"""Translate the text provided after "----------" to {target_language}.
.

We can change it if necessary @anna-geller.

@anna-geller
Copy link
Member Author

what do you mean with the prompt? it doesn't exclude the sidebar 😅

What I meant is: "Get a demo" or "Open an issue" could be translated, WDYT? seems better that way -- seems like an issue to tackle in translations JSON files, not in the .py script, am I wrong?

@anna-geller
Copy link
Member Author

ahh I see - you thought I meant "Flows" -- I should have specified - I meant the NEW RIGHT sidebar. Sorry for the confusion!

@anna-geller anna-geller changed the title Sidebar is not included in translations The new right sidebar is not included in translations (Open an issue, Get a demo etc) Dec 13, 2024
@MilosPaunovic
Copy link
Member

MilosPaunovic commented Dec 13, 2024

Sorry, my bad, just saw the left sidebar JA/EN combo and thought that's the problem. But you're right, this can be easily done.

If someone from the community want to contribute, only add new string to en.json file, we have automation which will handle all other languages.

@MilosPaunovic MilosPaunovic added the good first issue Great issue for new contributors label Dec 13, 2024
@arpitgupta-it
Copy link

I can take this up!

@MilosPaunovic
Copy link
Member

Absolutely, go for it @arpitgupta-it! 🚀

@arpitgupta-it
Copy link

I see that the context bar already has strings for the new sidebar present in the en.json file. Am I missing some context here? @MilosPaunovic

image

@MilosPaunovic
Copy link
Member

Maybe they just aren't applied to the right component?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working good first issue Great issue for new contributors
Projects
Status: Backlog
Development

No branches or pull requests

3 participants