Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a CSS sweep to align with latest version of Sass #6390

Open
MilosPaunovic opened this issue Dec 11, 2024 · 2 comments · May be fixed by #6412
Open

Do a CSS sweep to align with latest version of Sass #6390

MilosPaunovic opened this issue Dec 11, 2024 · 2 comments · May be fixed by #6412
Assignees
Labels
area/frontend Needs frontend code changes kind/cooldown Great candidate for the cooldown period

Comments

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Dec 11, 2024

Cooldown period might be a good time to do a full sweep of CSS to align with latest version of Sass, which produces warnings when we remove the artificial silencing of the logger from vite.config.js file:

preprocessorOptions: {
   scss: {
      logger: sass.Logger.silent
   },
}

This should be done in EE repository also.

@MilosPaunovic MilosPaunovic added area/frontend Needs frontend code changes kind/cooldown Great candidate for the cooldown period labels Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Dec 11, 2024
@elevatebart
Copy link
Contributor

A lot of issues come straight from bootstrap.

twbs/bootstrap#40962 (comment)

They don't want to fix the deprecations. It would remove compatibility with node-sass.
I think we should postpone until they have fixed it.

Let's change one thing though: "only silence the needed warning"

@MilosPaunovic
Copy link
Member Author

Yup, agreed.

@elevatebart elevatebart linked a pull request Dec 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes kind/cooldown Great candidate for the cooldown period
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

2 participants