You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've looked into GitHub user search project and found out that views contain unnecessary property wrappers (@State). According to WWDC sessions those shouldn't appear in such context. I removed them and search continued working correctly. I assume it'd be helpful removing them from repo to prevent newbies in Combine study on project with mistakes. Also I found out that project contains parts that are not used at all. I guess I can provide PR if needed)
Thank you for this amazing repo btw! I also speak Russian if that helps.
The text was updated successfully, but these errors were encountered:
I've looked into GitHub user search project and found out that views contain unnecessary property wrappers (@State). According to WWDC sessions those shouldn't appear in such context. I removed them and search continued working correctly. I assume it'd be helpful removing them from repo to prevent newbies in Combine study on project with mistakes. Also I found out that project contains parts that are not used at all. I guess I can provide PR if needed)
Thank you for this amazing repo btw! I also speak Russian if that helps.
The text was updated successfully, but these errors were encountered: