-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2 features - isSilentOnStartup + PTZCommandButtons Tool #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added sub configuration on 'start on startup' setting: is silent on startup; Used to get the app to automatically maximize on startup (simulate a light 'kiosk' mode) Added 'PTZ command buttons' tool- View tab checkbox option creates a floating bar with dynamically added ptz preset buttons (configured according to the currently focused camera). Options aids user to choose the presets when using a small touch-screen;
CommandButtons window save location
added cmd_ShutdownComputer to user buttons panel options
fixed ptz button control handling, now without list. caused bug when someone added manual preset with duplicate names
for physical joystick - (d > 10) enlarging 'quiet' circle around joystick center - to prevent PT noise and drift, when joystick center is a bit unstable;
ispysoftware
approved these changes
May 1, 2023
err yeah sorry, i'll merge and try it out |
Orvani
added a commit
to Orvani/iSpy
that referenced
this pull request
Jun 6, 2023
…joystick, 1. Fixed issue with commit ispysoftware#201 handle when there are no commands available; 2. Upgrade to users infrastructure - password check gets done on startup even when app is not minimized; 3. Last active user is saved to config, and is loaded on next app launch with password check 4. Added more features to user-defined visibility control; 5. Added configurable PTZ speed profile - default and high-sensitivity, (high sensitiviy profile allows slower speed and higher control over PT via joystick); profiles can be toggled via mainform commands and via joystick buttons 6. Fixed PTZ physical joystick : When no camera window is focused - bind the physical joystick input to the last active camera, or else the joystick input is ignored until user actively chooses a camera window again; ( this is not user-friendly when user selects other gui windows such as PTZTool, PTZCommandButtons, and remotecommands window, and therefore moves the screen focus from the cameras, resulting in c.Focused = false for all _pnlCameras.Controls;)
ispysoftware
pushed a commit
that referenced
this pull request
Jun 29, 2023
…#259) * User-password, added visibility Featursets, added PT Speed toggle on joystick, 1. Fixed issue with commit #201 handle when there are no commands available; 2. Upgrade to users infrastructure - password check gets done on startup even when app is not minimized; 3. Last active user is saved to config, and is loaded on next app launch with password check 4. Added more features to user-defined visibility control; 5. Added configurable PTZ speed profile - default and high-sensitivity, (high sensitiviy profile allows slower speed and higher control over PT via joystick); profiles can be toggled via mainform commands and via joystick buttons 6. Fixed PTZ physical joystick : When no camera window is focused - bind the physical joystick input to the last active camera, or else the joystick input is ignored until user actively chooses a camera window again; ( this is not user-friendly when user selects other gui windows such as PTZTool, PTZCommandButtons, and remotecommands window, and therefore moves the screen focus from the cameras, resulting in c.Focused = false for all _pnlCameras.Controls;) * Added null protection Added null protection * edited the visibility on File menu items leaving only open object list to enable config restore * Added virtual keyboard for PT preset setup and more Added virtual keyboard for PT preset setup; Fixed saving joystick buttons config for ptSpeed ; Added more feature visibility control on high-level-user; * Added menu option to load config.xml file Added option to load config.xml file PTZcommandButtons - if menu checkbox is on, the window will display even if there are no available presets to display. Display can be turned off using the menu checkbox. This is the same behavior as in PTZControl presets combobox, otherwise it causes other display issues which /i can't solve.
ispysoftware
added a commit
that referenced
this pull request
Jul 5, 2023
… Addition to pull request #259 (#261) * User-password, added visibility Featursets, added PT Speed toggle on joystick, 1. Fixed issue with commit #201 handle when there are no commands available; 2. Upgrade to users infrastructure - password check gets done on startup even when app is not minimized; 3. Last active user is saved to config, and is loaded on next app launch with password check 4. Added more features to user-defined visibility control; 5. Added configurable PTZ speed profile - default and high-sensitivity, (high sensitiviy profile allows slower speed and higher control over PT via joystick); profiles can be toggled via mainform commands and via joystick buttons 6. Fixed PTZ physical joystick : When no camera window is focused - bind the physical joystick input to the last active camera, or else the joystick input is ignored until user actively chooses a camera window again; ( this is not user-friendly when user selects other gui windows such as PTZTool, PTZCommandButtons, and remotecommands window, and therefore moves the screen focus from the cameras, resulting in c.Focused = false for all _pnlCameras.Controls;) * Added null protection Added null protection * edited the visibility on File menu items leaving only open object list to enable config restore * Added virtual keyboard for PT preset setup and more Added virtual keyboard for PT preset setup; Fixed saving joystick buttons config for ptSpeed ; Added more feature visibility control on high-level-user; * Added menu option to load config.xml file Added option to load config.xml file PTZcommandButtons - if menu checkbox is on, the window will display even if there are no available presets to display. Display can be turned off using the menu checkbox. This is the same behavior as in PTZControl presets combobox, otherwise it causes other display issues which /i can't solve. * Fixed - PTZCommandButtons disappears when min-max-ing video windows Fixed small bug in last commit - PTZCommandButtons disappears when min-max-ing video windows; sorry :) --------- Co-authored-by: sean t <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #200
Added 2 features - isSilentOnStartup + PTZCommandButtons Tool
1.isSilentOnStartup
added sub configuration on 'start on startup' Settings tab:
is silent on startup; Used to get the app to automatically maximize on startup (simulate a light 'kiosk' mode)
PTZCommandButtons Tool
Added 'PTZ command buttons' tool- on View tab, checkbox option creates a floating bar with dynamically added ptz preset buttons (configured according to the currently focused camera). Options aids user to choose the presets when using a small touch-screen;