Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Agent] Umlaute in camera names not properly encoded in webview #270

Open
SaculRennorb opened this issue Dec 6, 2023 · 5 comments
Open

Comments

@SaculRennorb
Copy link

Using any umlaut, e.g. ü in the name of a device will properly show that name in the server console, but render as the replacement character in the webview.

@ispysoftware
Copy link
Owner

ispysoftware commented Dec 7, 2023

hello whereabouts in the web view? what web browser are you using?
image
image
image

@SaculRennorb
Copy link
Author

Using FF version 120.0 (64-bit)

Interestingly I'm unable to reproduce this now,
but it was in the title of the edit device (?) modal.
grafik

I cannot figure out what I'm doing different now, but I'm certain it wasn't encoded properly a few hours ago. I cannot remember if reloading the page changed anything, but it was happening multiple times before I reported it.

Unfortunately this is one of those 'largely irrelevant' things I want paying much attention to after the fact.

@SaculRennorb
Copy link
Author

SaculRennorb commented Dec 7, 2023

Ha
grafik
grafik

grid view -> new device -> just selected a dummy one and put umlaute in the name -> ok -> now its broken everywhere

@ispysoftware
Copy link
Owner

I think this is probably more a bug in firefox - have you tried it in chrome - unable to reproduce it there

@SaculRennorb
Copy link
Author

Hm, you're right. I also cannot repro this using Chrome.
From my experience its usually Chrome doing something that's not to spec but lib authors relying on that, and FF just not doing that off spec thing. But tbh I have no idea what would be causing it in this case, since any apis for dynamically creating nodes have been out for quite a while and should be well tested.

I recently had something similar happen where if you don't specify the encoding in the meta tag of the html header Chrome assumes its CP 1252 (i think) while FF just assumes the much more reasonable UTF8, which would break special ascii characters in chrome. No idea if this is relevant here.

But I guess that's it then, not really a priority to work on this but I guess its nice to track the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants