Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'peakVelocity_times' from QC trials table #853

Open
k1o0 opened this issue Oct 4, 2024 · 2 comments
Open

Remove 'peakVelocity_times' from QC trials table #853

k1o0 opened this issue Oct 4, 2024 · 2 comments
Assignees
@k1o0

Comments

@k1o0
Copy link
Contributor

k1o0 commented Oct 4, 2024

Peak velocity times are per wheel movement, not per trial and should therefore be removed from the QC trials table.
@k1o0 k1o0 mentioned this issue Oct 4, 2024
Closed
k1o0 added a commit that referenced this issue Oct 15, 2024
@k1o0
Resolves #853
af96df2
bimac added a commit that referenced this issue Oct 16, 2024
@bimac
Revert "Resolves #853"
bbf915d 
This reverts commit af96df2.
@bimac
Copy link
Contributor

bimac commented Oct 16, 2024

This wasn't the root cause ...

The truncation of peakVelocity_times to the number of trials (which causes it to be displayed in the trials table) happens during syncing of timestamps between bpod and fpga: see ephys_fpga.py#L945-L948.

@bimac
Copy link
Contributor

bimac commented Oct 16, 2024 •
edited
Loading

should we track the truncation in a separate issue?

bimac added a commit that referenced this issue Oct 16, 2024
@bimac
Reapply "Resolves #853"
5e54694 
This reverts commit bbf915d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@k1o0 k1o0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bimac @k1o0