Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deduplication does not work if count is omitted. Should error instead. #4282

Open
digikata opened this issue Dec 3, 2024 · 0 comments
Open
Labels
bug Something isn't working
Milestone

Comments

@digikata
Copy link
Contributor

digikata commented Dec 3, 2024

What happened
When omitting count: from topic deduplication crd, the setup can prevent client connector to the topic.

Expected behavior
Rejection of the misconfigured field or an error log which points to the missing 'count' value if deduplication is enabled

Describe the setup
A user on discord 1 was able to setup a topic with two configs, one of which (missing count, was failing to connect.

Working config

# topic.yaml
version: 0.1.0
meta:
  name: grpc-txs
deduplication:
  bounds:
    count: 5 # remember at least 5 last records
    age: 5s # remember records for at least 5 seconds
  filter:
    transform:
      uses: infinyon-labs/[email protected]

Failing config. Note the missing 'count' field under deduplication.

apiVersion: fluvio.infinyon.com/v2
kind: Topic
metadata:
  name: grpc-txs
  namespace: fluvio
spec:
  cleanupPolicy:
    segment:
      timeInSeconds: 86400
  replicas:
    computed:
      partitions: 3
      replicationFactor: 2
  deduplication:
    bounds:
      age: 5s
    filter:
      transform:
        uses: infinyon-labs/[email protected]
@digikata digikata added bug Something isn't working enhancement New feature or request labels Dec 3, 2024
@ajhunyady ajhunyady changed the title Enhancment: Deduplication does not work if count is omitted. Should error instead. Dec 4, 2024
@ajhunyady ajhunyady removed the enhancement New feature or request label Dec 4, 2024
@ajhunyady ajhunyady added this to the 0.11.2 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants