Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Redundant None Check for vector_similarity_weight #4037

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove Redundant None Check for vector_similarity_weight #4037

wants to merge 1 commit into from
+0 −2

Conversation

learnerLj
Copy link

What problem does this PR solve?

The removed if statement is unnecessary and adds cognitive load for readers.
The original code:

vector_similarity_weight = req.get("vector_similarity_weight", 0.3)
if vector_similarity_weight is None:
    vector_similarity_weight = 0.3

has been simplified to:

vector_similarity_weight = req.get("vector_similarity_weight", 0.3)

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@learnerLj