Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drag and drop with @hello-pangea/dnd #513

Closed
mehdiraized opened this issue Jan 17, 2024 · 8 comments · Fixed by #616
Closed

drag and drop with @hello-pangea/dnd #513

mehdiraized opened this issue Jan 17, 2024 · 8 comments · Fixed by #616
Labels
enhancement New feature or request help wanted Extra attention is needed possible discussion Not exactly a bug or a feature request, but rather something that could or should be discussed

Comments

@mehdiraized
Copy link
Contributor

mantine has sample for drag and drop rows in table
but we need access to row render for use this package and add this feature
https://ui.mantine.dev/category/dnd/

image

@icflorescu icflorescu added enhancement New feature or request help wanted Extra attention is needed labels Jan 20, 2024
@icflorescu
Copy link
Owner

Other users requested the feature too but no one came up with a valid PR so far, and I'm afraid I don't have the luxury of free time at the moment.

So, I'm 💯 percent open to a PR regarding this!

@icflorescu icflorescu pinned this issue Jan 20, 2024
@MohdAhmad1
Copy link
Contributor

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

@icflorescu
Copy link
Owner

I'm really curious to see other people's feedback on the PR addressing this issue. My primary concern in regarding the addition of a new mandatory dependency (Pangea DnD).

@icflorescu icflorescu added the possible discussion Not exactly a bug or a feature request, but rather something that could or should be discussed label Jul 10, 2024
@mehdiraized
Copy link
Contributor Author

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

@MohdAhmad1
Copy link
Contributor

I have created a pr to address this issue, check it here #616 , I just found out that a issue for same already exists

can you change your code and create a new page in Examples, if you want to use the Pangea DnD, you can install the package and put the sample code on that page.

I have already added an example page in /examples/row-dragging/

@mehdiraized
Copy link
Contributor Author

i fixed this issue on this commit
ee6b61b

@mehdiraized
Copy link
Contributor Author

@icflorescu can you check that PR ?
everything is ok in this PR please check that

@icflorescu
Copy link
Owner

Thanks for the outstanding work, release is on its way to npm registry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed possible discussion Not exactly a bug or a feature request, but rather something that could or should be discussed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants