Fix perso event names #2554
Fix perso event names #2554
Conversation
To see if this is why my changes are marked as invalid by GitHub
| { | ||
| "recommendationItems": [ |
There was a problem hiding this comment.
We should provide a full response here, in an external file, not an extract. And, if needed, highlight lines related to the topic.
| } | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
It doesn't really looks like https://github.com/ibexa/personalization/blob/v4.6.14/tests/fixtures/recommendations/response-body.json
| @@ -387,7 +373,7 @@ See [Recommendation API](recommendation_api.md) for more details. | |||
| A trigger message includes requests for a Triggeropened and Clicktriggered event. | |||
There was a problem hiding this comment.
Maybe use the properties of the trigger message below, triggerOpenedLink and clickTriggered?
| @@ -355,24 +355,10 @@ The first one is executed when a recommendation is shown to the user. | |||
| The second is called when a recommendation is clicked or otherwise accepted. | |||
| Sending Rendered events causes as many requests as recommendations to be displayed, a Clickrecommended event is usually sent only once (when a user clicks on a specific recommendation item). | |||
There was a problem hiding this comment.
Why not "clickRecommended" has in the example below?
| Sending Rendered events causes as many requests as recommendations to be displayed, a Clickrecommended event is usually sent only once (when a user clicks on a specific recommendation item). | |
| Sending Rendered events causes as many requests as recommendations to be displayed, a `clickRecommended` event is usually sent only once (when a user clicks on a specific recommendation item). |
It's probably its label name instead of its property name. Could be "Click recommended" in this case, a bit like "Clicked recommended" from its summary https://github.com/ibexa/personalization/blob/v4.6.14/src/lib/Value/Performance/Summary/Event.php#L19
Or all-caps "CLICKRECOMMENDED" like in https://doc.ibexa.co/projects/userguide/en/master/personalization/event_types/
| Example of a trigger message: | ||
|
|
There was a problem hiding this comment.
This is again a JSON sample without consideration for parse errors.
I didn't find a test or other reference for this one.
code_samples/ change report
|
Fix personalization event names capitalization and code style.
Preview: https://ez-systems-developer-documentation--2554.com.readthedocs.build/en/2554/personalization/api_reference/tracking_api/
Checklist