IBX-9274: Context menu does not show up in 'Location' folder #1404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
force-pushed
the
IBX-9274-Image-picker-context-menu-not-show-up-under-Location
branch
3 times, most recently
from
3e3eb28 to
66dea38
Compare
lucasOsti
force-pushed
the
IBX-9274-Image-picker-context-menu-not-show-up-under-Location
branch
from
66dea38 to
09a758e
Compare
lucasOsti
requested review from
GrabowskiM,
tischsoic,
dew326,
bozatko and
a team
dew326
approved these changes
Dec 11, 2024
GrabowskiM
approved these changes
Dec 11, 2024
ViniTou
approved these changes
Dec 13, 2024
konradoboza
approved these changes
Dec 13, 2024
Steveb-p
approved these changes
Dec 13, 2024
ciastektk
approved these changes
Dec 13, 2024
|
bozatko
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
For backend reviewers:
Endpoint
/api/ibexa/v2/module/universal-discovery/locations?locationIds=1,2,3always return permissions only for the last location from thelocationIdsparameter. The problem was methodLocationListDataVisitor->visitwhich iterates through the list of locations$data->getLocationList(), with each iteration it made astartList, which create new list with one element instead of adding location data to it.For QA:
Documentation: