Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7800: Removed Sub-items tab for non-containers without children #1189

Draft
wants to merge 2 commits into
base: 4.6
Choose a base branch
from
Draft

IBX-7800: Removed Sub-items tab for non-containers without children #1189

wants to merge 2 commits into from

Conversation

Nattfarinn
Copy link
Contributor

Question Answer
JIRA issue IBX-7800
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Nattfarinn Nattfarinn requested a review from a team February 22, 2024 09:28
ViniTou
ViniTou reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@ViniTou ViniTou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why this is not using \Ibexa\Contracts\AdminUi\Tab\ConditionalTabInterface?

@Nattfarinn
Copy link
Contributor Author

Any reason why this is not using \Ibexa\Contracts\AdminUi\Tab\ConditionalTabInterface?

Cause I did not remember such thing exists :D Good call.

@mnocon mnocon added the Doc needed The changes require some documentation label Feb 23, 2024
@Nattfarinn Nattfarinn requested a review from ViniTou March 1, 2024 07:23
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

konradoboza
konradoboza approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@konradoboza konradoboza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 but PHPStan needs to be adjusted. Besides, we should target 4.6 I think.

@Nattfarinn Nattfarinn force-pushed the ibx-7800-sub-items-tab branch from b14080a to 0838a16 Compare April 25, 2024 07:14
@Nattfarinn Nattfarinn force-pushed the ibx-7800-sub-items-tab branch from 0838a16 to 84fda4f Compare May 16, 2024 07:42
@Nattfarinn Nattfarinn changed the base branch from main to 4.6 May 16, 2024 07:43
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Nattfarinn Nattfarinn marked this pull request as draft June 13, 2024 08:20
@mikadamczyk
Copy link
Contributor

@Nattfarinn PHPStan needs to be adjusted here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@webhdx webhdx webhdx approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@ViniTou ViniTou Awaiting requested review from ViniTou

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Doc needed The changes require some documentation Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Nattfarinn @mikadamczyk @webhdx @ViniTou @konradoboza @ciastektk @mnocon