Ignore incoming pending transactions when sync mode is blockchair #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is because in blockchair sync mode we don't sync all the blocks after the checkpoint. Instead, we only sync blocks where blockchair says we have a transaction. Thus, if we receive an incoming transaction "A" which is replaced by another transaction "B" (that sends funds to another wallet) in the mempool, we won't receive "B" from blockchair (because it's not related to any of our addresses), and so "A" is left in 'pending' state on our list of transactions. A 'pending' transaction is left forever, and the user may think the funds are still on the way, whereas in fact, they were sent to another wallet.
abdrasulov
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is because in blockchair sync mode we don't sync all the blocks after the checkpoint. Instead, we only sync blocks where blockchair says we have a transaction. Thus, if we receive an incoming transaction "A" which is replaced by another transaction "B" (that sends funds to another wallet) in the mempool, we won't receive "B" from blockchair (because it's not related to any of our addresses), and so "A" is left in 'pending' state on our list of transactions. A 'pending' transaction is left forever, and the user may think the funds are still on the way, whereas in fact, they were sent to another wallet.