Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README examples (causing low performance) #98

Open
kirqz23 opened this issue Feb 2, 2021 · 0 comments
Open

Fix README examples (causing low performance) #98

kirqz23 opened this issue Feb 2, 2021 · 0 comments

Comments

@kirqz23
Copy link

kirqz23 commented Feb 2, 2021

Hi,

There is an issue in README examples:
https://github.com/heroku/salesforce-bulk/blame/main/README.rst#L66
https://github.com/heroku/salesforce-bulk/blame/main/README.rst#L75

IteratorBytesIO is not needed cause the function already returns it.

return util.IteratorBytesIO(iter)

What I've noticed is that when you run result = json.load(IteratorBytesIO(result)) instead of result = json.load(result) my script is running 35 min vs 2 min. It can cause problems for other users as well in opened issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant