Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded GE requirements list from search queries #2297

Open
hawkrives opened this issue Oct 9, 2018 · 3 comments
Open

Remove hard-coded GE requirements list from search queries #2297

hawkrives opened this issue Oct 9, 2018 · 3 comments
Labels
bug

Comments

@hawkrives
Copy link
Owner

hawkrives commented Oct 9, 2018 •
edited
Loading

After demo day

Currently, you can search for "WRI" or "SPM", and the search understands that you're looking for courses matching a GE.

That list of GEs is hard-coded into the module.

We should … not hard-code it.
@drewvolz
Copy link
Collaborator

drewvolz commented Oct 9, 2018

Yeah. Let's consume the list produced by https://stodevx.github.io/course-data/data-lists/valid_gereqs.json

@hawkrives
Copy link
Owner Author

Or fetch them from the database, or …

@drewvolz
Copy link
Collaborator

drewvolz commented Oct 9, 2018 •
edited
Loading

The database? ah, locally.

@hawkrives hawkrives changed the title Remove hard-coded GE requirements Remove hard-coded GE requirements list from search queries Oct 10, 2018
@hawkrives hawkrives added the bug label Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hawkrives @drewvolz