Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider defining the DTR pin state as part of the protocol standard #14

Open
bruno-f-cruz opened this issue Dec 6, 2023 · 4 comments · May be fixed by #34
Open

Consider defining the DTR pin state as part of the protocol standard #14

bruno-f-cruz opened this issue Dec 6, 2023 · 4 comments · May be fixed by #34
Assignees
Labels
under review An issue that is undergoing pr review under testing Someone is having testing this feature

Comments

@bruno-f-cruz
Copy link
Member

Related to bonsai-rx/harp#81

@artursilva0
Copy link
Contributor

Since this is a serial communication specific pin, shouldn't this pin state be specified in the core implementation instead?

In my opinion the Harp protocol (which is just one part of the Harp Standard) should be as much agnostic as possible to the communication protocols.

@bruno-f-cruz
Copy link
Member Author

This spec doesn't need to necessarily go into the protocol, I would probably but it in the Device. The same way that the baudrate of the synchronization protocol is not defined in its own document.

@glopesdev
Copy link
Collaborator

Feedback from SRM meeting:

  • What does "connected" mean in the protocol specification?
    • @filcarv clarified the intention of "connected" as the host application opening a serial connection to the device.
    • DTR might open the opportunity for more devices to participate in the current client implementation
    • @glopesdev and @artursilva0 suggested that we leave the communication protocol open to any physical transport layer, but just specify that the transport layer needs to provide a way for devices to define "connected" and "not connected" states. In practice we can set DTR to true in the current C# client

@bruno-f-cruz bruno-f-cruz linked a pull request Jan 28, 2024 that will close this issue
@bruno-f-cruz bruno-f-cruz linked a pull request Feb 22, 2024 that will close this issue
@bruno-f-cruz
Copy link
Member Author

This has been added to the new Bonsai version. I will make the draft into a PR to be reviewed.

@bruno-f-cruz bruno-f-cruz added the under review An issue that is undergoing pr review label Feb 29, 2024
@bruno-f-cruz bruno-f-cruz self-assigned this Feb 29, 2024
@bruno-f-cruz bruno-f-cruz added the under testing Someone is having testing this feature label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
under review An issue that is undergoing pr review under testing Someone is having testing this feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants