Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Short hand description notation in device.yml breaks reader #34

Open
bruno-f-cruz opened this issue Jul 23, 2024 · 3 comments
Open

Short hand description notation in device.yml breaks reader #34

bruno-f-cruz opened this issue Jul 23, 2024 · 3 comments

Comments

@bruno-f-cruz
Copy link
Member

Leaving this here so i dont forget later.

For instance:
https://github.com/harp-tech/device.timestampgeneratorgen3/blob/a463d1dbb60346034e6f77a956b3e0bd28bbd28d/device.yml#L71

Will throw a parsing error from pydantic.

@glopesdev
Copy link
Contributor

glopesdev commented Nov 4, 2024

This should be fixed with harp-tech/protocol@bd4d52a. Do you think we can close this? If the issue is with low-level pydantic I'm not sure there is much we can do at the level of this library...

@bruno-f-cruz
Copy link
Member Author

Yap, can confirm it fixes it. However, from the point of view of the device.yml, this will be a breaking change no? The example above is actually a use in the device yml itself (https://github.com/harp-tech/device.timestampgeneratorgen3/blob/a463d1dbb60346034e6f77a956b3e0bd28bbd28d/device.yml#L71)

@glopesdev
Copy link
Contributor

@bruno-f-cruz the generators have been updated to support both formats, so as long as it is possible to update the device.yml itself, it shouldn't be a problem. Or were you thinking of other breaking changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants