Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Trailing Slash Behavior #177

Open
jpengelbrecht opened this issue Jan 30, 2024 · 4 comments
Open

Default Trailing Slash Behavior #177

jpengelbrecht opened this issue Jan 30, 2024 · 4 comments

Comments

@jpengelbrecht
Copy link

Describe the bug

if a link ends in .html, it makes .html/. which breaks it.
image

i dont think you should force external links to use trailing /. for instance https://myaccount.google.com/permissions/ is invalid for there server where https://myaccount.google.com/permissions so not.

Reproduction

No response

System / Nuxt Info

No response

@jpengelbrecht
Copy link
Author

looking at the code is see you just used the new nuxt experimental nuxtlink,
image

however now users cannot opt out of this entirely even though its still very experimental, thus the bugs

@harlan-zw
Copy link
Owner

The bug is within the NuxtLink itself which isn't experimental. So it's an upstream issue that I already have a pr in progress for nuxt/nuxt#25435

@jpengelbrecht
Copy link
Author

@harlan-zw I meant trailingSlash option in NuxtLink is still experimental. Its still under the experimental object

@harlan-zw
Copy link
Owner

harlan-zw commented Feb 2, 2024

I've made an issue for the upstream bug here nuxt/nuxt#25532 (comment)

Will revert the original change for RC 6

@harlan-zw harlan-zw changed the title latest version does weird things on links and adds / where it shouldnt Default Trailing Slash Behavior Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants