-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the error types in the nutype package #75
Comments
@gensmusic Hi! Thanks for raising this. The primary motivation for having dedicated error types is to force users:
But since there is a demand for a generic/common error type, I consider to implement some easy-to-use conversions into that common error type from specific error type. I will keep this issue open, so I keep this in mind. |
What are your current thoughts on this issue? I am currently hesitating against using In #161 you mention that people want to customize the errors. Maybe adding a way to provide "context" to customize the error message is enough? In my experience people mostly just want to bubble errors up and print them. Is pattern matching the possible validation failure modes on a newtype common use case? Is it worth the extra complexity? |
@DJDuque To illustrate this using Though I understand there are different personal preferences and different use cases. Some times just a healthy trade off needs to be made. At the moment I working on #161, and it will be soon done. |
Hi,
I'm writing to you today to suggest that you consider unifying the error types for each struct in the nutype package. Currently, each struct has its own enum error type, which can make it difficult to track and handle errors.
I propose that we unify the error types into a single error type called ValidateError. This would make it easier to track and handle errors, as we would only need to handle a single error type instead of multiple error types.
I believe that this change would be a valuable improvement to the nutype package. Thank you for your time and consideration.
The text was updated successfully, but these errors were encountered: